-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera-Terrain interaction #1817
Conversation
…d the mouse starts from space.
No need to do this now, but if you think it is worth it, write an issue to middle-mouse rotate in 2D rotate depend on the mouse location like 3D. |
|
In Columbus view this can be awkward when looking straight down. Have a look and see if there's anything you think we should do. |
Browsing around Seneca Rocks, WV is much better. |
Not sure that it is the right fix, but fixing #1670 would also fix this. |
Actually just run viewer, zoom to "Nepal", zoom in a bit, and try to tilt and it tilts backwards. |
That's all for now. I'll test again and look at the code when ready. |
@bagnell any update? We should aim to merge this week so it has some time in master before 1.0. |
Conflicts: Apps/Sandcastle/gallery/3D Models.html Source/DataSources/EntityView.js Source/Scene/GlobeSurface.js Source/Scene/GlobeSurfaceTile.js Source/Scene/Scene.js Specs/Scene/GeometryRenderingSpec.js
Conflicts: CHANGES.md
Conflicts: Apps/Sandcastle/gallery/3D Models.html Apps/Sandcastle/gallery/Camera.html CHANGES.md
… screen until the camera height is low enough to pick terrain.
…rrain when its close enough to pick the terrain.
All critical fixes are in. @bagnell please write issues (and link them to the camera roadmap) for any outstanding issues that we should address later. I'll have a another look at the code now. |
return undefined; | ||
} | ||
|
||
//while(tile.state === QuadtreeTileLoadState.DONE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this?
Folks - let us know if you run into any significant issues in master with this... |
This is a huge improvement to camera handling, great work on this. |
For #449, #549, and #1060.
IntersectionTests
:rayTriangle
,lineSegmentTriangle
,raySphere
, andlineSegmentSphere
.Globe.getHeight
andGlobe.pick
for finding the terrain height at a given Cartographic coordinate and picking the terrain with a ray.